-
Notifications
You must be signed in to change notification settings - Fork 10
Benchmarking #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Benchmarking #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worked around the #14 issue with write timeouts onr ead deadlocks by having the server drop messages instead. The benchmarks now show that the client write thread starves the read thread, as the write rate keeps increasing while the read rate plummets, and the drop ratio goes up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary results show a ~100% performance improvement from using the native
websocket_mask
extension: ~3000/s -> ~6000/s before overloadResults (non-dropping mode)
The benchmarks fail with write timeouts once the client saturates. This is caused by the read thread deadlocking on the blocked socket write with the driver mutex held: #14
With
websocket-driver
fromwebsocket-driver-kontena
(pure-rubywebsocket/mask
)With
websocket-driver
fromwebsocket-driver
(nativewebsocket_mask
extension)Results (drop mode)
Running the
websocket-echo-server
in-drop
mode, where the server drops messages if it reads them faster than the client reads the echo responses. This shows that the client write thread is starving the read thread, as the write rate keeps increasing, but the read rate declines and messages start getting dropped.With
websocket-driver
fromwebsocket-driver-kontena
(pure-rubywebsocket/mask
)With
websocket-driver
fromwebsocket-driver
(nativewebsocket_mask
extension)