chore: fix grammatical and spelling errors in comments and tests #1490
+44
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1490 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 487 487
Branches 136 136
=========================================
Hits 487 487
Continue to review full report at Codecov.
|
miwnwski
reviewed
Jul 16, 2020
lib/request.js
Outdated
| @@ -422,7 +422,7 @@ module.exports = { | |||
| * When `app.proxy` is `true`, parse | |||
| * the "X-Forwarded-For" ip address list. | |||
| * | |||
| * For example if the value were "client, proxy1, proxy2" | |||
| * For example if the values were "client, proxy1, proxy2" | |||
There was a problem hiding this comment.
I disagree, a string is one value.
There was a problem hiding this comment.
Makes sense, I adjusted it from "the values were" to the "the value was", squashed the commits, and pushed.
dead-horse
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a handful of small things with regards to spelling and grammar as I've been digging through this code as of recent. Even though small, I hope this helps. If these changes seem reasonable, then let me know if you'd like me to take any further action or make adjustments.