-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Koa v3 Tracker #1837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Regarding the goal to move to Jest; please don't. Use the native Node.js test runner! It should be more than adequate. You can pair it with |
to add, Node test runner has identical API to Jest for assertion, |
Vitest is another fairly lightweight option for jest-compatible test runner. My last experience was that Jest is terrible to use with ESM as it doesn't fully support it yet. vitest is much better in this regard. A rewrite might also be a nice time to take a look at including only minimal dependencies (e.g. https://npmgraph.js.org/?q=koa vs https://npmgraph.js.org/?q=polka) |
I just realized that I already migrated it to jest a while go haha. if anyone is interested in migrating to node's official test runner, that would be great. otherwise, I will leave it as is |
## Checklist use `node --test` instead of `jest` See: #1837 (comment) - [X] I have ensured my pull request is not behind the main or master branch of the original repository. - [X] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first. - [X] I have written a commit message that passes commitlint linting. - [X] I have ensured that my code changes pass linting tests. - [X] I have ensured that my code changes pass unit tests. - [X] I have described my pull request and the reasons for code changes along with context if necessary.
👍 to |
Just need to spend time to write a migration doc for v3 and then I am going to launch it |
I know this is blasphemy these days, so at the risk of sounding like a luddite, I have to beg you, PLEASE, PLEASE don't convert Koa to ESM-Only unless you'll be actively updating/patching the v2 branch for an extended period of time (like multiple years). Migrating existing NodeJS codebases to ESM still isn't effortless, and going to ESM-only risks leaving CJS users in a vulnerable state where they can't safely upgrade to incorporate security patches and critical bug fixes. |
why would you want to migrate existing codebases to a semver incompatible version of a web framework without upgrading Node.js? starting version 20.x you can require(esm) so in case you're on that version, you can safely use Koa as ESM |
let me know if anyone contributed that I missed in the release notes https://github.com/koajs/koa/releases/tag/v3.0.0 |
@jonathanong I have a big thank for your hard working, but I'm worried about how many popular middlewares will be broken by this major upgrading, do we have a draft list in the latest migration guide? |
@TechQuery it should just be |
actually, |
Koa v3.0 was featured in Node Weekly today at https://nodeweekly.com/issues/576 as was our @forwardemail blog post https://forwardemail.net/en/blog/docs/how-npm-packages-billion-downloads-shaped-javascript-ecosystem 🚀 |
Starting a new tracker for v3
Milestone: https://github.com/koajs/koa/milestone/4
Other Breaking Changes:
Future:
Tests:
Improved Documentation:
The text was updated successfully, but these errors were encountered: