Skip to content

bump cert-manager, istio, contour #15928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jun 13, 2025

No description provided.

@knative-prow knative-prow bot requested review from dsimansk and skonto June 13, 2025 16:59
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2025
Copy link

knative-prow bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2025
@dprotaso
Copy link
Member Author

/assign @dsimansk @Fedosin @skonto

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.94%. Comparing base (ed1e3d7) to head (5f39dbf).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15928      +/-   ##
==========================================
- Coverage   80.99%   80.94%   -0.05%     
==========================================
  Files         210      210              
  Lines       16780    16780              
==========================================
- Hits        13591    13583       -8     
- Misses       2837     2843       +6     
- Partials      352      354       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2025
@dprotaso
Copy link
Member Author

/retest

1 similar comment
@dprotaso
Copy link
Member Author

/retest

@Fedosin
Copy link
Contributor

Fedosin commented Jun 17, 2025

/test https

@dprotaso
Copy link
Member Author

The https tests never pass according to

https://testgrid.k8s.io/r/knative-own-testgrid/serving#https

@dprotaso
Copy link
Member Author

Existing issue is here: #14435

Can I get a /lgtm - I wanted to bump the dependencies to get releases to a supported version

@dprotaso
Copy link
Member Author

/override "https_serving_main"

Copy link

knative-prow bot commented Jun 17, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: https_serving_main

In response to this:

/override "https_serving_main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
@knative-prow knative-prow bot merged commit 29e580b into knative:main Jun 17, 2025
65 checks passed
@dprotaso dprotaso deleted the bump-networking branch June 18, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants