Skip to content

mcp: adds delete tool and adds remote flag to deploy tool #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

mcp: adds delete tool and adds remote flag to deploy tool #2863

wants to merge 2 commits into from
+42 −1

Conversation

KapilSareen
Copy link
Contributor

@KapilSareen KapilSareen commented Jun 12, 2025 •
edited
Loading

Changes

  • adds the delete tool to func's MCP server.
  • adds the --remote flag to deploy tool

Related Epic #2806

@knative-prow knative-prow bot requested review from dsimansk and vyasgun June 12, 2025 21:06
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 12, 2025

Hi @KapilSareen. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 62.29%. Comparing base (e9e88e5) to head (1c1a7e9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/mcp/mcp.go 0.00% 37 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
+ Coverage   62.07%   62.29%   +0.21%     
==========================================
  Files         129      129              
  Lines       15767    15803      +36     
==========================================
+ Hits         9787     9844      +57     
+ Misses       5066     5015      -51     
- Partials      914      944      +30
Flag Coverage Δ
e2e-tests 35.06% <0.00%> (-6.75%) ⬇️
integration-tests 48.92% <0.00%> (+1.70%) ⬆️
unit-tests 49.00% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lkingland
lkingland requested changes Jun 12, 2025
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make "name" optional?

pkg/mcp/mcp.go
mcp.WithDescription("Deletes a function from the cluster"),
mcp.WithString("name",
mcp.Required(),
mcp.Description("Name of the function to be deleted"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that "name" is an optional parameter, and if not provided, the function in cwd is deleted (using the name found in its func.yaml)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with that, I have explain it more on slack.

lkingland
lkingland approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 17, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 17, 2025
@KapilSareen KapilSareen changed the title mcp: adds delete tool mcp: adds delete tool and adds remote flag to deploy tool Jun 17, 2025
lkingland
lkingland approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KapilSareen, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkingland
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

@vyasgun vyasgun Awaiting requested review from vyasgun

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KapilSareen @lkingland @knative-prow-robot