Skip to content

feat: adds command for mcp server #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KapilSareen
Copy link
Contributor

This PR aims to add func mcp command which can be used to start a MCP (Model Context Protocol) server.

Part of #2690

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2025
Copy link

knative-prow bot commented May 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KapilSareen
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from jrangelramos and nainaz May 25, 2025 13:07
Copy link

knative-prow bot commented May 25, 2025

Hi @KapilSareen. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2025
Copy link

codecov bot commented May 25, 2025

Codecov Report

Attention: Patch coverage is 48.33333% with 31 lines in your changes missing coverage. Please review.

Project coverage is 63.41%. Comparing base (a062cd2) to head (5c071b5).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pkg/mcp/mcp.go 0.00% 21 Missing ⚠️
cmd/mcp.go 69.69% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2836      +/-   ##
==========================================
+ Coverage   62.64%   63.41%   +0.77%     
==========================================
  Files         127      129       +2     
  Lines       15533    15631      +98     
==========================================
+ Hits         9730     9912     +182     
+ Misses       4892     4776     -116     
- Partials      911      943      +32     
Flag Coverage Δ
e2e-tests 43.64% <48.33%> (+1.51%) ⬆️
integration-tests 49.41% <48.33%> (+1.80%) ⬆️
unit-tests 49.54% <48.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KapilSareen KapilSareen force-pushed the mcp-01 branch 2 times, most recently from a7decfd to b409731 Compare May 29, 2025 12:46
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2025
@KapilSareen KapilSareen force-pushed the mcp-01 branch 2 times, most recently from a90e941 to 11a1d68 Compare June 2, 2025 11:36
@KapilSareen KapilSareen marked this pull request as ready for review June 2, 2025 11:37
@KapilSareen KapilSareen changed the title WIP: adds command for mcp server feat: adds command for mcp server Jun 2, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2025
Signed-off-by: KapilSareen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant