-
Notifications
You must be signed in to change notification settings - Fork 152
Make docker.io/heroku/ builders trusted #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
===========================================
- Coverage 61.59% 48.41% -13.18%
===========================================
Files 131 129 -2
Lines 15794 15785 -9
===========================================
- Hits 9728 7643 -2085
- Misses 5155 7455 +2300
+ Partials 911 687 -224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PTAL @lkingland @gauron99 @matzew |
@lkingland @matzew plz override "codecov/project", it's failing probably because I created the PR via github web UI and therefore in the repository (not in fork). |
/override codecov/project |
@gauron99: Overrode contexts on behalf of gauron99: codecov/project In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
codecov is failing because the PR is created in the base repo, not a fork... therefore the permissions are different and tokenless upload doesnt work |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.18 |
@gauron99: new pull request created: #2823 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Make heroku's builders trusted.
fixes #2516