Skip to content

[wip] Support multiple triggers on func subscribe command #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jrangelramos
Copy link
Contributor

@jrangelramos jrangelramos commented Apr 29, 2025

Changes

  • 🎁 Support multi triggers on func subcribe command

/kind enhancement

Fixes #2572

Release Note


Docs


Copy link

knative-prow bot commented Apr 29, 2025

@jrangelramos: The label(s) kind/enhancmeent cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🎁 Support multi triggers on func subcribe command

/kind enhancmeent

Fixes #2572

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Apr 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2025
@knative-prow knative-prow bot requested a review from dsimansk April 29, 2025 12:51
Copy link

knative-prow bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from nainaz April 29, 2025 12:51
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2025
@jrangelramos jrangelramos requested review from matzew, matejvasek and lkingland and removed request for dsimansk and nainaz April 29, 2025 12:51
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 44.61%. Comparing base (e013e6e) to head (8f60d4c).

Files with missing lines Patch % Lines
cmd/subscribe.go 80.64% 5 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (e013e6e) and HEAD (8f60d4c). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (e013e6e) HEAD (8f60d4c)
1 0
unit-tests-macos-latest 1 0
unit-tests-ubuntu-latest 1 0
integration-tests 1 0
unit-tests-windows-latest 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2816       +/-   ##
===========================================
- Coverage   61.59%   44.61%   -16.99%     
===========================================
  Files         131      110       -21     
  Lines       15794    14976      -818     
===========================================
- Hits         9728     6681     -3047     
- Misses       5155     7484     +2329     
+ Partials      911      811      -100     
Flag Coverage Δ
e2e-test 35.38% <80.64%> (+0.03%) ⬆️
e2e-test-oncluster 33.72% <0.00%> (+1.34%) ⬆️
e2e-test-oncluster-runtime 28.16% <0.00%> (?)
e2e-test-runtime-go 25.74% <0.00%> (?)
e2e-test-runtime-node 25.09% <0.00%> (?)
e2e-test-runtime-quarkus 25.18% <0.00%> (?)
e2e-test-runtime-rust 24.65% <0.00%> (?)
e2e-test-runtime-springboot 24.72% <0.00%> (?)
e2e-test-runtime-typescript 25.18% <0.00%> (?)
integration-tests ?
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrangelramos jrangelramos changed the title Support multiple triggers on func subscribe command [wip] Support multiple triggers on func subscribe command Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple triggers on kn-subscribe
1 participant