Skip to content

Enable arm64 python buildpack #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025

Conversation

matejvasek
Copy link
Contributor

Changes

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Apr 14, 2025

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 14, 2025
@knative-prow knative-prow bot requested review from nainaz and rhuss April 14, 2025 18:35
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.44%. Comparing base (09c934d) to head (60bd511).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2789      +/-   ##
==========================================
+ Coverage   61.61%   62.44%   +0.82%     
==========================================
  Files         131      131              
  Lines       15794    15794              
==========================================
+ Hits         9731     9862     +131     
+ Misses       5153     4993     -160     
- Partials      910      939      +29     
Flag Coverage Δ
e2e-test 35.40% <ø> (+0.04%) ⬆️
e2e-test-oncluster 33.82% <ø> (+1.40%) ⬆️
e2e-test-oncluster-runtime 28.16% <ø> (?)
e2e-test-runtime-go 25.73% <ø> (?)
e2e-test-runtime-node 25.09% <ø> (?)
e2e-test-runtime-quarkus 25.17% <ø> (?)
e2e-test-runtime-rust 24.68% <ø> (?)
e2e-test-runtime-springboot 24.70% <ø> (?)
e2e-test-runtime-typescript 25.09% <ø> (?)
integration-tests 48.62% <ø> (+1.79%) ⬆️
unit-tests 48.66% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor Author

@lkingland pzl override the linter error fix is in another PR.

@matejvasek
Copy link
Contributor Author

@lkingland plz override failing tests

Signed-off-by: Matej Vašek <[email protected]>
@matejvasek matejvasek removed request for rhuss and nainaz April 15, 2025 11:22
@matejvasek
Copy link
Contributor Author

PTAL @gauron99

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
Copy link

knative-prow bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 33b9f15 into knative:main Apr 15, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants