Skip to content

Cleanup: Codecov update, unify flags and ignore unwanted files #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Apr 7, 2025

Changes

  • 🧹 Removes unnecessary flags/coverages (runtimes tests)
  • 🧹 remove unnecessary workaround file
  • 🧹 ignore dirs that dont contain code we want to cover (.codecov.yaml changes)
  • Unify the flags so that we have only 3 clear ones -- unit integration e2e

/kind cleanup

Copy link

knative-prow bot commented Apr 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2025
@knative-prow knative-prow bot requested review from dsimansk and rhuss April 7, 2025 08:55
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2025
@knative knative deleted a comment from knative-prow bot Apr 7, 2025
@gauron99 gauron99 removed request for rhuss and dsimansk April 7, 2025 08:56
@gauron99 gauron99 changed the title [WIP]2 [WIP] -- codecov Apr 7, 2025
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2025
@knative knative deleted a comment from codecov bot Apr 8, 2025
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2025
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2025
@knative knative deleted a comment from codecov bot May 2, 2025
@knative knative deleted a comment from codecov bot May 2, 2025
@knative knative deleted a comment from codecov bot May 4, 2025
@knative knative deleted a comment from codecov bot May 4, 2025
@knative knative deleted a comment from codecov bot May 5, 2025
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.44%. Comparing base (688a39e) to head (c949c86).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
+ Coverage   61.59%   63.44%   +1.84%     
==========================================
  Files         131      127       -4     
  Lines       15796    15533     -263     
==========================================
+ Hits         9730     9855     +125     
+ Misses       5155     4738     -417     
- Partials      911      940      +29     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster ?
e2e-tests 43.59% <ø> (?)
integration-tests 49.45% <ø> (+2.64%) ⬆️
unit-tests 49.49% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 marked this pull request as ready for review May 5, 2025 09:58
@knative-prow knative-prow bot requested review from nainaz and vyasgun May 5, 2025 09:58
@gauron99 gauron99 requested review from matejvasek and lkingland and removed request for nainaz and vyasgun May 5, 2025 09:58
@gauron99
Copy link
Contributor Author

gauron99 commented May 5, 2025

@matejvasek @lkingland PTAL

@gauron99 gauron99 changed the title [WIP] -- codecov Cleanup: Codecov update, unify flags and ignore unwanted files May 5, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
Copy link

knative-prow bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 55df89a into knative:main May 12, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants