Skip to content

Remove axios dependency #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Remove axios dependency #2293

wants to merge 3 commits into from

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented May 7, 2024 •
edited
Loading

Changes

  • Removed dependency on axios by using fetch().
  • Fixed getLatestPlatform() by using the tag_name property instead of the name property.

@matejvasek
fix: downgrade Java version for Spring Boot
fcfe65a 
The newer version of Spring Boot does not work with Java 21

Signed-off-by: Matej Vašek <[email protected]>
@knative-prow knative-prow bot requested review from maximilien and vyasgun May 7, 2024 14:47
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2024
@matejvasek
chore: replace axios with fetch()
eb1337e 
* Removed dependency on axios by using standard node fetch() function.
* Fixed getLatestPlatform(): using the 'tag_name' property instead of the 'name' property.

Signed-off-by: Matej Vašek <[email protected]>
@matejvasek
Copy link
Contributor Author

PTAL @trisberg @lkingland @matzew

@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.72%. Comparing base (b97d841) to head (37d6749).
Report is 79 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
- Coverage   64.21%   60.72%   -3.50%     
==========================================
  Files         108      127      +19     
  Lines       13918    14779     +861     
==========================================
+ Hits         8937     8974      +37     
- Misses       4108     4905     +797     
- Partials      873      900      +27
Flag Coverage Δ
e2e-test 38.44% <ø> (+1.06%) ⬆️
e2e-test-oncluster 31.52% <ø> (+1.01%) ⬆️
e2e-test-oncluster-runtime 27.67% <ø> (?)
e2e-test-runtime-go 26.21% <ø> (?)
e2e-test-runtime-node 27.22% <ø> (?)
e2e-test-runtime-python 27.17% <ø> (?)
e2e-test-runtime-quarkus 27.26% <ø> (?)
e2e-test-runtime-rust 26.29% <ø> (?)
e2e-test-runtime-springboot 26.35% <ø> (?)
e2e-test-runtime-typescript 27.34% <ø> (?)
integration-tests 49.93% <ø> (+0.07%) ⬆️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest 48.98% <ø> (-0.61%) ⬇️
unit-tests-windows-latest 47.60% <ø> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

matejvasek commented May 7, 2024 •
edited
Loading

@trisberg Why the newer Spring Boot works only with Java 17 not 21?

@trisberg
Copy link
Member

trisberg commented May 7, 2024

@trisberg Why the newer Spring Boot works only with Java 17 not 21?

It should work with Java 21, I use that all the time. What is the error and the failing config?

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkingland
Copy link
Member

/lgtm
/hold for potential fix enabling Java 21

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@matejvasek
Copy link
Contributor Author

@trisberg Why the newer Spring Boot works only with Java 17 not 21?

It should work with Java 21, I use that all the time. What is the error and the failing config?

oops I probably used old version of Java when testing locally

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@matejvasek
Copy link
Contributor Author

PTAL @lkingland

@matejvasek matejvasek requested a review from lkingland May 7, 2024 16:03
@matejvasek
Copy link
Contributor Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@matejvasek
Copy link
Contributor Author

I have idea why the coverage fails. @dsimansk @ReToCode please override it.

@lkingland
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@matejvasek
Copy link
Contributor Author

/override codecov/project

@knative-prow Knative Prow
Copy link

knative-prow bot commented May 10, 2024

@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators.

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Contributor Author

Why the **** is there codecov/project twice?

@matejvasek
Copy link
Contributor Author

I just created completely new PR.

@matejvasek matejvasek closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisberg trisberg Awaiting requested review from trisberg

@matzew matzew Awaiting requested review from matzew

@gauron99 gauron99 Awaiting requested review from gauron99

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @trisberg @lkingland