added PodSecurityContext

[Sanket-0510]

Changes

Schema for PodSecurityContext so that users can define fields like fsGroup

/kind Enhancement

Fixes #2108

[knative-prow]

Hi @Sanket-0510. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lkingland]

I am grateful for this contribution.
Could we please run gofmt on the files? there's a few formatting problems that are causing our linters to complain.

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

[lkingland]

This PR is in the right ballpark. Can we get the code formatted with gofmt and then we can have a discussion about the implementation itself?

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sanket-0510
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Sanket-0510]

Hey @lkingland I will do the needed and we can discuss it further

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Sanket-0510 / name: Sanket Teli (a3f6e06, 2091749, 195733f, 98a79ad, f56dce1)

[Sanket-0510]

hey sorry for the delay in response but I have formatted the code and pushed the changes

[lkingland]

Thanks for coming back to help finish.

For the Unit tests to pass, I think all that needs to be done here is to remove the extraneous whitespace, and run $ make to get a regenerated schema yaml.

However, I looked into the error from the validator says it disallows setting the pod security context.

The security context may need to be set at the container level instead. We can confirm with the Knative Serving folks on Slack, but it would effectively be this:

spec:
  template:
    spec:
      containers:
      - image: my-image
        securityContext:  # This is correct - at container level
          runAsUser: 1000
          allowPrivilegeEscalation: false

[lkingland]

You can remove the extraneous space prepended to "omitempty" here

[lkingland]

We should confirm with the Serving team, but this may need to be renamed SecurityContext and set at the Container level in the Knative Deployer in order to clear up the validation webhook error.