Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntegrationSink: OIDC test #8524

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

matzew
Copy link
Member

@matzew matzew commented Mar 12, 2025

Fixes #

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Mar 12, 2025
@knative-prow knative-prow bot requested a review from evankanderson March 12, 2025 14:37
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 12, 2025
@knative-prow knative-prow bot requested a review from mgencur March 12, 2025 14:37
Copy link

knative-prow bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@matzew matzew force-pushed the integration_sink_oidc branch from 9e323d0 to 3d508cf Compare March 12, 2025 14:38
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.44%. Comparing base (4fd274a) to head (3d508cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8524   +/-   ##
=======================================
  Coverage   52.44%   52.44%           
=======================================
  Files         397      397           
  Lines       24869    24869           
=======================================
  Hits        13042    13042           
  Misses      11041    11041           
  Partials      786      786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

matzew and others added 3 commits March 13, 2025 16:33
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew matzew force-pushed the integration_sink_oidc branch from 9446dfe to a9d1afc Compare March 13, 2025 15:33
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2025
Copy link

knative-prow bot commented Mar 13, 2025

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_eventing_main a9d1afc link true /test build-tests
unit-tests_eventing_main a9d1afc link true /test unit-tests
reconciler-tests_eventing_main a9d1afc link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants