Skip to content

Add PILOT_ENABLED_SERVICE_APIS to manifest #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Add PILOT_ENABLED_SERVICE_APIS to manifest #620

wants to merge 6 commits into from

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented May 11, 2021

Istio needs this option to support Gateway API (Ingress v2).
If istio manifest could enable the option by default, serving repo
will add Gateway API support with the manifest in net-istio wihtout
change.

/cc @arturenault @dprotaso @markusthoemmes

@nak3 nak3 requested review from a team as code owners May 11, 2021 09:25
@nak3 nak3 requested review from a team and tcnghia May 11, 2021 09:25
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 11, 2021
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021 •
edited
Loading

Codecov Report

Merging #620 (6aa71d6) into main (0a2badf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   78.80%   78.80%           
=======================================
  Files          18       18           
  Lines        1109     1109           
=======================================
  Hits          874      874           
  Misses        148      148           
  Partials       87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2badf...6aa71d6. Read the comment docs.

@arturenault
Copy link
Contributor

Looks like codegen is failing, otherwise lgtm

arturenault
arturenault previously approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@arturenault arturenault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arturenault
To complete the pull request process, please ask for approval from nak3 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2021
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 16, 2021
@knative-prow-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2021
howardjohn
howardjohn reviewed May 19, 2021
View reviewed changes
third_party/istio-head/istio-ci-mesh.yaml
@@ -24,6 +24,8 @@ spec:
autoscaleMax: 10
cpu:
targetAverageUtilization: 60
env:
PILOT_ENABLED_SERVICE_APIS: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is default in latest istio fwiw

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thank you! Istio v1.10+ enabled it by default.Then, we should update to 1.10 by #631 first then add this option in 1.9 only.

@nak3
Copy link
Contributor Author

nak3 commented Jun 2, 2021

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2021
@nak3
Copy link
Contributor Author

nak3 commented Jun 17, 2021

Closing as 1.10 enabled the option by default and istio-latest uses 1.10.1 now.

@nak3 nak3 closed this Jun 17, 2021
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2021
@knative-prow-robot
Copy link
Contributor

@nak3: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

@arturenault arturenault arturenault left review comments

@tcnghia tcnghia Awaiting requested review from tcnghia

@dprotaso dprotaso Awaiting requested review from dprotaso

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

Assignees

@arturenault arturenault

Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nak3 @arturenault @knative-prow-robot @howardjohn