-
Notifications
You must be signed in to change notification settings - Fork 87
Persistent high CPU load on some web sites #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you please try the latest Alpha (you have to disable the normal first): https://github.com/kkapsner/CanvasBlocker/releases/tag/0.5.4-Alpha3 |
Please try 0.5.4: https://github.com/kkapsner/CanvasBlocker/releases/tag/0.5.4 |
I'm on 0.5.4 and the problem still exists. Here's an address that will produce the problem without fail: https://www.windowscentral.com/how-use-custom-environments-windows-mixed-reality |
Well... this pages requests ~200 DOMRect values per second - it seems that it's the ads. If I simply activate µBlock the number of requested DOMRects and therefore the CPU loads goes down. As CB fakes this value I'm not surprised that you see an CPU load increase. But there is little I can do about it. I already try to be as efficient as possible. PS: you will not see the high DOMRect numbers as CB only reports once for requests for the same object. |
Can you please check which protection causes the problems on the other pages? |
I use ublock origin and umatrix, is there a rule or something I should add to keep this from happening? Disabling CB makes my cpu idle normally but I've only got like 70 notifications from ublock+umatrix+disconnect combined. I'm not sure what the other pages were that ended up freezing firefox and I can't think of any other add-ons that would be interfering. Not knocking your efficiency either, with the exception of the random page that goes from 5% to 100% like a supercar, I haven't noticed any performance impact. |
I do not know of a specific rule. I also use NoScript which also helps. With number of notifications I mean the number in the page action popup (see screenshot in first comment). |
Can you give an example link for amazon? It runs well for me. The amiunique thing is known and there is not really anything I can do about it - they use a very poorly written script. |
@Leeweez I can't reproduce this issue either.. maybe open a new Issue, to share detailed information about your configurations and console logs? |
Same for me. Page scrolls fine. |
For me, it slows down on amazon when the mouse is on the image product and the zoomed version appears to the right. |
Sorry for the delay, i see the following: |
Can you please give me your settings? |
Here they are (i've whitelisted amazon)
|
Hm... I do not see anything bad there. Does the problem persist when you disable the DOMRect protection? |
Hi, |
Hm... I still cannot reproduce but I recommend that you then only disable the DOMRect API for amazon and not whitelist it completely. |
Thanks, but it is not clear to me how to disable just the DOMRect API for a specific site. -EDIT- |
Someone on a forum had an old Windows XP box that he had to disable CanvasBlocker on as it caused websites like Amazon to become choppy like others have mentioned and he all so had to disable it on a more modern Linux skylake box as 60fps media at Youtube would stutter but was perfectly fine when CanvasBlocker was disabled so something is causing a high overhead or I/O polling that it's not always practical to use? It might be something to do with Firefoxes API as other extensions can become sluggish on certain pages as i've noticed this with lastpass taking forever. |
I always recommend to identify the part of CB that causes the slowdown (in the case of Youtube I would guess it's the DOMRect-API). The problematic parts can be disabled individually (also on a site by site level). |
I'm getting Firefox errors CanvasBlocker is slowing things down on https://steamdb.info. This is what CanvasBlocker reports after the page loads (for instance, on the Sales page):
|
It's working fine for me - what are your settings and versions (Firefox/CB)? |
Other than appearance settings I'm running on the default CB settings. Testing it a bit more over the past two days the warning seems to appear only sometimes now. It could be that the official SteamDB Firefox addon could be conflicting with something, I'll test it out some more. |
Hello Korbinian, I would not go so far as to notify the Eclipsed Moon developers. I mean, they're doing the best they can. |
Hm... I'm not quite sure where to put such a comment so it's not too in the way but the people read it. |
@kkapsner Maybe put such a disclaimer just in the descriptions here and on AMO for now? |
Sounds like a good idea. |
Done |
This is website that triggers persistent script/CPU warning: Also, it happens on Twitter. The warning doesn't occur, but Disqus discussions won't even display without CB disabled. |
I don't get a single CanvasBlocker notification or warning on this page. Please check the notifications to get to know which API/scripts trigger the CB protection. Twitter is probably the DOM-Rect API. It usually gets a little bit better if you disable the notifications for DOM-Rect. I have no clue about the Disqus problem (but I know that their technological approach is horrible). Can you give me an example page? |
I've just installed this extension today and can attest to it causing serious performance issues. Observe: https://aelius.keybase.pub/canvasblocker%20amazon%20image%20performance.mp4 |
Also, even when I'm not interacting with the Amazon webpage, firefox is chewing through 20% of my CPU when canvas blocker is loaded. Disabling canvasblocker and refreshing the page allows firefox to idle again. (I've since read through the thread and excluded amazon from DOM-Rect api, which does sidestep the issue) |
I am aware of this issue but have no good idea how to solve it. There is no good way to distinguish between fingerprinting and legit use of the DOMRect-API. Maybe I should analyse the amazon code to get the exact problem... |
The code at amazon is not great. It seems to me that they read the DOMRect more often than necessary. The numbers I get when I count every readout are insane (several thousand for one mouse movement). So the only thing I can do is to improve the overall performance of the DOMRect API. |
Additional factor 2.6 = total factor 4.7 (For #253).
I managed to get some performance improvements. The zoomed view at amazon is better but far of being good. |
Thanks kkapsner! I'm thinking... |
Hi,thx for the great addon! |
Total improvement compared to 0.5.8: 7.2 (For #253)
With the latest improvements the amazon page is usable. Not good, but usable. |
Please test the latest 0.5.9 as it has some performance improvements. |
Definitely better, thank you! |
I think with 0.5.10 the performance is acceptable. So I will close this issue. If someone still has an example page that uses lots of CPU or is slow I can reopen this issue. |
thank you so much..it's working for my website https://ecogenn.com |
I was having performance issues on Amazon as well, when hovering on an image (it zooms in on it), if I move the mouse, the CPU would increase to 15% and memory would rise; at some point it reached 4GB for an Amazon tab, and the "zoom navigation" was choppy and slow. I use many extensions, and I pinpointed that CB was causing the problem. Enabling or disabling HW acceleration didn't help. So, after reading this thread, I found that indeed the DOM-Rect had the highest hits: I disabled it as you instructed here #253 (comment) and now the image zooming is fluid again. I used amazon.*, is that a correct usage? Newegg has a similiar zooming feature as Amazon, their DomRect started around 30 hits and after a while it went up to 200, however it doesn't cause any slowdowns (if it does, I know how to fix it now). My question is, when disabling the DOM-Rect API for a specific site, does it affect the fingerprint faking? |
It will match the mentioned domains. But also something like
It affects the fingerprinting through the DOM-Rect API. But all the other ways are still protected. |
While the tab is selected, I am seeing high CPU usage in Firefox on some web sites… as if a thread is remaining active and the process never completes. When I disable CanvasBlocker in about:addons and select the tab again, Firefox CPU loading for the page has returned to its normal idle state.
Example: https://homebiogas.com/
The text was updated successfully, but these errors were encountered: