Skip to content

Don't set the N bit for literals. #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Don't set the N bit for literals. #41

merged 1 commit into from
Sep 2, 2024

Conversation

kixelated
Copy link
Owner

This is causing quic-go to reject the connection. It's a bug on their end, but there's no harm in unsetting the bit since it doesn't do anything.

The following bit, 'N', indicates whether an intermediary is permitted to add this field line to the dynamic table on subsequent hops. When the 'N' bit is set, the encoded field line MUST always be encoded with a literal representation. In particular, when a peer sends a field line that it received represented as a literal field line with the 'N' bit set, it MUST use a literal representation to forward this field line. This bit is intended for protecting field values that are not to be put at risk by compressing them; see Section 7.1 for more details.

This is causing quic-go to reject the connection. It's a bug on their end,
but there's no harm in unsetting the bit since it doesn't do anything.
@kixelated kixelated merged commit 1d19605 into main Sep 2, 2024
1 check passed
@kixelated kixelated deleted the fix-n branch September 2, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant