Update green normal #4712
Merged
Update green normal #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLM Analysis of PR ChangesSummaryThis pull request updates the Key Points to Review
Style & Consistency
|
|
Storybook staging is available at https://kiwicom-orbit-dsil-update-green-normal.surge.sh Playroom staging is available at https://kiwicom-orbit-dsil-update-green-normal.surge.sh/playroom |
|
Size Change: +1 B (0%) Total Size: 464 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
23ef4c0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2468c2a.orbit.pages.dev |
| Branch Preview URL: | https://dsil-update-green-normal.orbit.pages.dev |
|
No new screenshots? 😮 |
|
@mvidalgarcia I was also surprised. I am assuming the change isn't big enough 😅 |
mvidalgarcia
approved these changes
Apr 14, 2025
DSil
force-pushed
the
dsil/update-green-normal
branch
from
6f47696 to
23ef4c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as a fix since it's a small fix from a very recent release.
FEPLT-2430
✨
Description by Callstackai
This PR updates the green color values across various files to correct the color representation for success indicators.
Diagrams of code changes
sequenceDiagram participant DT as Design Tokens participant CSS as CSS Variables participant Components as UI Components DT->>DT: Update paletteGreenNormal<br/>value to #048724 DT->>CSS: Generate Success Color Tokens Note over CSS: Update success-related colors:<br/>#048724 for normal state<br/>rgb(4, 135, 36) for RGB format CSS->>Components: Apply Updated Colors Note over Components: Update success variants for:<br/>- Alert icons<br/>- Badges<br/>- Buttons<br/>- Text elements<br/>- Icons Components-->>CSS: Consume new color values CSS-->>DT: Complete token propagationFiles Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.snap,.json,.css,.less,.scss,.styl,.xml. See list of supported languages.