Sarka/badge list item gap #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLM Analysis of PR ChangesSummaryThis PR refactors the Key Points to Review
Style & Consistency
|
|
Storybook staging is available at https://kiwicom-orbit-sarka-badge-list-item-gap.surge.sh Playroom staging is available at https://kiwicom-orbit-sarka-badge-list-item-gap.surge.sh/playroom |
|
Size Change: +47 B (+0.01%) Total Size: 464 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
79f4983
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6411b6df.orbit.pages.dev |
| Branch Preview URL: | https://sarka-badge-list-item-gap.orbit.pages.dev |
sarkaaa
force-pushed
the
sarka/badge-list-item-gap
branch
from
f883b5c to
e32ba95
Compare
sarkaaa
force-pushed
the
sarka/badge-list-item-gap
branch
from
e32ba95 to
be782be
Compare
sarkaaa
force-pushed
the
sarka/badge-list-item-gap
branch
from
be782be to
79f4983
Compare
DSil
reviewed
Apr 14, 2025
...ts/src/List/List.ct.tsx-snapshots/visual-List-List-with-various-spacing-1-Desktop-darwin.png
Show resolved
Hide resolved
Ajuska
approved these changes
Apr 14, 2025
DSil
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://kiwicom.atlassian.net/browse/FEPLT-2427
This Pull Request meets the following criteria:
For new components:
d.tsfiles and are exported inindex.d.ts✨
Description by Callstackai
This PR modifies the
BadgeListItemandListItemcomponents to adjust spacing and improve the overall layout. It also updates the README files to reflect the new default spacing values.Diagrams of code changes
sequenceDiagram participant App participant BadgeList participant List participant SPACINGS Note over BadgeList,List: Adding spacing functionality App->>BadgeList: Create with spacing prop BadgeList->>SPACINGS: Get ONE_HUNDRED default value BadgeList-->>App: Render with spacing classes App->>List: Create with spacing prop List->>SPACINGS: Get ONE_HUNDRED default value List-->>App: Render with spacing classes Note over BadgeList,List: Both components now support<br/>configurable spacing between itemsFiles Changed
ItemWrapperto adjust spacing.spacingprop description to include a default value.spacingprop usingSPACINGS.ONE_HUNDRED.ListItemto improve layout.spacingprop description to include a default value.spacingprop usingSPACINGS.ONE_HUNDRED.This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.md. See list of supported languages.