feat(tailwind): add new safe- classes #4704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLM Analysis of PR ChangesSummaryThis PR introduces new Tailwind utility classes ( Key Points to Review
|
|
Storybook staging is available at https://kiwicom-orbit-domi-add-safe-area-class.surge.sh Playroom staging is available at https://kiwicom-orbit-domi-add-safe-area-class.surge.sh/playroom |
|
Size Change: +2 B (0%) Total Size: 464 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
c803274
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aa522a7f.orbit.pages.dev |
| Branch Preview URL: | https://domi-add-safe-area-class.orbit.pages.dev |
domihustinova
force-pushed
the
domi/add-safe-area-class
branch
from
3379a0a to
f068a1d
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- packages/orbit-tailwind-preset/src/tests/snapshots/configs.test.ts.snap: Language not supported
Comments suppressed due to low confidence (1)
packages/orbit-tailwind-preset/src/index.ts:351
- Consider adding tests for the newly introduced 'safe-' spacing tokens to verify that the correct CSS variables and fallbacks are applied across different environments.
spacing: {
DSil
approved these changes
Apr 11, 2025
domihustinova
force-pushed
the
domi/add-safe-area-class
branch
from
f068a1d to
c803274
Compare
mvidalgarcia
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEPLT-2363
✨
Description by Callstackai
This PR adds new safe-area classes to the Tailwind preset, enhancing the utility for handling safe area insets.
Diagrams of code changes
sequenceDiagram participant TC as Tailwind Config participant ST as Spacing Theme participant SA as Safe Area Variables TC->>ST: Add safe area spacing options ST->>SA: Define safe-top Note over SA: var(--safe-area-inset-top) ST->>SA: Define safe-right Note over SA: var(--safe-area-inset-right) ST->>SA: Define safe-bottom Note over SA: var(--safe-area-inset-bottom) ST->>SA: Define safe-left Note over SA: var(--safe-area-inset-left) SA-->>TC: Apply safe area values to multiple<br/>spacing-related propertiesFiles Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.snap. See list of supported languages.