Skip to content

Commit 695f452

Browse files
committed
feat(InputSelect): remove helpClosable prop
BREAKING CHANGE: The InputSelect component no longer accepts the helpClosable prop, since the help tooltip no longer renders the Close button.
1 parent 4a4b529 commit 695f452

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

packages/orbit-components/src/InputSelect/InputSelect.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,5 @@ export const Playground: Story = {
220220
tabIndex: "",
221221
id: "",
222222
insideInputGroup: false,
223-
helpClosable: false,
224223
},
225224
};

packages/orbit-components/src/InputSelect/README.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const options = [
4646
title: "Option 2",
4747
value: 2,
4848
description: "Description for option 2",
49-
group: "Group name"
49+
group: "Group name",
5050
},
5151
...
5252
];
@@ -89,7 +89,6 @@ The table below contains all types of props available in the InputSelect compone
8989
| maxHeight | `string` | `400px` | Specifies max height of the dropdown with results for InputSelect. |
9090
| onOptionSelect | `(opt: Option \| null) => void` | | Callback that fires when an option is selected. |
9191
| onClose | `(opt: Option \| null) => void` | | Callback that fires when the list of options is closed by other means than selecting an option. It is called with the value of the selected or null, if nothing is selected. |
92-
| helpClosable | `boolean` | `true` | Whether to display help as a closable tooltip, or have it open only while the field is focused, same as error. |
9392
| emptyState | `React.Node` | `"No results found."` | Message to display when no options are available. If a string is passed, paddings are automatically applied. |
9493
| labelClose | `string` | `Close` | The label for the close button in the dropdown. |
9594
| showAll | `boolean` | `true` | If set to true, it will display all options at the end of the list. If set to false, it will display only the options without a group at the end of the list. |

packages/orbit-components/src/InputSelect/types.d.ts

-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ export interface Props extends Common.Globals, Common.SpaceAfter, Common.DataAtt
3838
readonly readOnly?: boolean;
3939
readonly id?: string;
4040
readonly insideInputGroup?: boolean;
41-
readonly helpClosable?: boolean;
4241
readonly emptyState?: React.ReactNode;
4342
readonly labelClose?: string;
4443
readonly onChange?: React.ChangeEventHandler<HTMLInputElement>;

0 commit comments

Comments
 (0)