Skip to content

Commit 4a4b529

Browse files
committed
feat(InputGroup): remove helpClosable prop
BREAKING CHANGE: The InputGroup component no longer accepts the helpClosable prop, since the help tooltip no longer renders the Close button.
1 parent e21f46a commit 4a4b529

File tree

4 files changed

+1
-8
lines changed

4 files changed

+1
-8
lines changed

packages/orbit-components/src/InputGroup/InputGroup.stories.tsx

+1-4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ const meta: Meta<InputGroupPropsAndCustomArgs> = {
3434
args: {
3535
error: "",
3636
help: "",
37-
helpClosable: true,
3837
onChange: action("onChange"),
3938
onFocus: action("onFocus"),
4039
onBlur: action("onBlur"),
@@ -199,7 +198,7 @@ export const Error: Story = {
199198

200199
parameters: {
201200
controls: {
202-
exclude: ["onChange", "onFocus", "onBlur", "onBlurGroup", "size", "help", "helpClosable"],
201+
exclude: ["onChange", "onFocus", "onBlur", "onBlurGroup", "size", "help"],
203202
},
204203
},
205204

@@ -269,7 +268,6 @@ export const ValidationApproaches: Story = {
269268
"onBlurGroup",
270269
"error",
271270
"help",
272-
"helpClosable",
273271
"size",
274272
"spaceAfter",
275273
],
@@ -319,7 +317,6 @@ export const OnChangeBehavior: Story = {
319317
"onBlurGroup",
320318
"error",
321319
"help",
322-
"helpClosable",
323320
"size",
324321
"spaceAfter",
325322
],

packages/orbit-components/src/InputGroup/README.md

-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ Table below contains all types of the props available in InputGroup component.
3535
| onBlur | `event => void \| Promise` | | Function for handling onBlur event between different InputGroup children. [See Functional specs](#functional-specs) |
3636
| onBlurGroup | `event => void \| Promise` | | Function for handling onBlur event for the whole InputGroup. [See Functional specs](#functional-specs) |
3737
| spaceAfter | `enum` | | Additional `margin-bottom` after component. |
38-
| helpClosable | `boolean` | `true` | Whether to display help as a closable tooltip, or have it open only while the field is focused, same as error. |
3938

4039
### enum
4140

packages/orbit-components/src/InputGroup/index.tsx

-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ const InputGroup = React.forwardRef<HTMLDivElement, Props>(
3030
disabled,
3131
dataTest,
3232
spaceAfter,
33-
helpClosable = true,
3433
onFocus,
3534
onBlur,
3635
onChange,
@@ -172,7 +171,6 @@ const InputGroup = React.forwardRef<HTMLDivElement, Props>(
172171
<ErrorFormTooltip
173172
help={helpReal}
174173
error={errorReal}
175-
helpClosable={helpClosable}
176174
onShown={setTooltipShown}
177175
shown={tooltipShown || tooltipShownHover}
178176
referenceElement={labelRef}

packages/orbit-components/src/InputGroup/types.d.ts

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export interface Props extends Common.Globals, Common.SpaceAfter {
1010
readonly flex?: string | string[];
1111
readonly help?: React.ReactNode;
1212
readonly children: React.ReactNode;
13-
readonly helpClosable?: boolean;
1413
readonly onBlurGroup?: React.FocusEventHandler<HTMLDivElement>;
1514
readonly error?: React.ReactNode;
1615
readonly disabled?: boolean;

0 commit comments

Comments
 (0)