Make human readable short urls #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbucsy
changed the title
SepsiLaszlo
approved these changes
Jul 3, 2022
triszt4n
reviewed
Jul 3, 2022
triszt4n
reviewed
Jul 3, 2022
| end | ||
|
|
||
| def authorize_image | ||
| unless current_user.present? && (current_user.site_admin? || logged_in_as_admin_of?(album.circle) || album.shared?) |
There was a problem hiding this comment.
I think this line would be complete with only checking for album.shared?
There was a problem hiding this comment.
Otherwise anytime someone/some website would like to reach the image (for example, our blog), there should be a user logged in
There was a problem hiding this comment.
oh true, i forgot to check for public albums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this pr solves issue with the monkey patching private albums
and greatly shortens the path to images without introducing another redirect, so
it is easier for browsers to cache 🥳
It uses friendly_id gem to make human friendly urls from filenames.
The good part is we don't have to replace old links on the blog, because they will still work.
If PR is accepted please ping me, because i want to deploy it to lois. There is a data migration rake task, to move old images to the new AlbumImage model, but if something goes bad i want to be there to put out the dumpster fire 🔥
closes #91 and closes #90