Add support for mounting other filesystems in user namespaces #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgl
force-pushed
the
dgl/userns-otherfs
branch
2 times, most recently
from
de8145a to
b666bad
Compare
|
I'll check it out later this week, but skimming through it, SGTM. @alban can you take a look? |
alban
reviewed
Nov 30, 2023
Comment on lines
+15
to
16
| //go:build linux && cgo | ||
| // +build linux,cgo |
There was a problem hiding this comment.
Since we require go 1.18 (see go.mod), the new directive //go:build is necessarily supported and the old one is not required. Should we remove the old ones?
There was a problem hiding this comment.
I'll send a follow up PR, seems sensible.
|
Friendly ping? |
|
@rata sorry, updated now, I had to think about this more than expected ;) |
alban
approved these changes
Dec 13, 2023
Signed-off-by: David Leadbeater <[email protected]>
dgl
force-pushed
the
dgl/userns-otherfs
branch
from
af1ba34 to
836d609
Compare
Done :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow mounting other filesystems
...optionally only when CAP_SYS_ADMIN in a user namespace
When using a user namespace it is desirable that it acts like "host root", that is it has the ability to mount filesystems and so on. A bunch of this just works, e.g. tmpfs is allowed by the kernel itself. However it isn't possible to mount network filesystems.
This change adds the ability to configure a list of allowed filesystems, as well as passing the options through. This makes it possible to mount any file system configured. Whether it works will depend on the user's environment, as block devices generally won't be available within the container (and
-o loopsadly won't work because loopback and user namespaces don't mix well), however it will work for many network file systems, tested with cifs.cc @rata
How to use
See the readme.
Testing done
See the readme.