[WEB-696] FacebookResetPassword Improvements #1765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## circleci/pipeline-queue #1765 +/- ##
===========================================================
- Coverage 85.29% 85.29% -0.01%
===========================================================
Files 1276 1276
Lines 116541 116567 +26
Branches 30722 30725 +3
===========================================================
+ Hits 99408 99423 +15
- Misses 16066 16074 +8
- Partials 1067 1070 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
msadoon
approved these changes
Jan 16, 2023
Generated by 🚫 Danger |
scottkicks
added a commit
that referenced
this pull request
Jan 24, 2023
* [WEB-861] Consent Management feature flag (#1764) * Add new Consent Management Dialog feature flag * Add new Consent Management Dialog feature flag * remove failing view controller test assertion * formatting * Adding a small commit so tests pass on CI. Didn't realize that if we removed the feature from the mock client, the recording would would still have it in the snapshot and our old snapshot wouldn't have been updated yet. * formatting Co-authored-by: Mubarak Sadoon <[email protected]> * [WEB-696] FacebookResetPassword Improvements (#1765) * remove ResetYourFacebookPasswordViewController snapshots * rename viewmodel and viewcontroller * viewmodel form logic suggestions * update viewmodel tests * ensure the scrollview is not hidden by the keyboard * set returnKeyType to go and make api call on tap * update accessibility on set your password view controller * updated accessibility for facebookresetpasswordviewcontroller. * formatting Co-authored-by: Mubarak Sadoon <[email protected]> * [WEB-669] Facebook Conversions API Feature Flag (#1766) * add facebook conversions api feature flag * add facebook conversions api feature flag * fix test * [WEB-862] AppTrackingTransparency Authorization (#1772) * set NSUserTrackingUsageDescription in plist * request ATTrackingAuthorization on app applicationdidFinishLaunching * formatting * gate behind consent management dialog feature flag * pr feedback * ATTrackingAuthorizationStatus to its own file * Use `.ksr_debounce` on Signal instead of `asyncAfter` * Handle `restricted` and `@unknown` requestTrackingAuthorization status cases * Improve unit test * use ksr_delay insted of ksr_debounce Co-authored-by: Mubarak Sadoon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Making some improvements to the ResetYourFacebookPassword screen that was added in #1763
🤔 Why
Event though the original code works and is mostly clean there are some improvements that can be made in order to conform to KS best practices and account for some accessibility edge cases
Feedback being addressed can be found here
🛠 How
ResetYourFacebookPasswordViewControllersnapshots have been removed to avoid the M1 related issues we're seeing with generating snapshots.goand hook up to the on submit api callNew Behavior
❗️Important Notes❗️
circleci/pipeline-queuefor the time being