New OpenShift service mesh section inside integrations #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshaughn
requested changes
Oct 3, 2022
There was a problem hiding this comment.
Hi @josunect, this looks good. I like the idea of an Integrations section and I think it makes sense to be at the bottom, underneath the sections that deal with standalone Kiali. I have one suggested revision for a sentence with a grammar issue. Feel free to revise my revision :-)
Co-authored-by: Jay Shaughnessy <[email protected]>
Thanks, @jshaughn ! It looks more clear and friendly :) |
jshaughn
approved these changes
Oct 3, 2022
josunect
added a commit
to josunect/kiali.io
that referenced
this pull request
Oct 3, 2022
* New ossmc section * ossmc * Put integrations at the bottom * Update content/en/docs/Integrations/ossm-console.md Co-authored-by: Jay Shaughnessy <[email protected]> Co-authored-by: Jay Shaughnessy <[email protected]>
hhovsepy
added a commit
that referenced
this pull request
Oct 4, 2022
New OpenShift service mesh section inside integrations (#585)
hhovsepy
pushed a commit
to hhovsepy/kiali.io
that referenced
this pull request
Apr 5, 2024
* New ossmc section * ossmc * Put integrations at the bottom * Update content/en/docs/Integrations/ossm-console.md Co-authored-by: Jay Shaughnessy <[email protected]> Co-authored-by: Jay Shaughnessy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not sure where to place the new page.
I've created a new section, "Integrations", but it could be moved directly to a OSSMC section or inside other page.
Feedback is welcome!
https://deploy-preview-585--kiali.netlify.app/docs/integrations/ossm-console/