Skip to content

adaptation join spec #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 31, 2024
Merged

adaptation join spec #36

merged 13 commits into from
Jul 31, 2024

Conversation

elsdvlee
Copy link
Collaborator

@elsdvlee elsdvlee commented Jul 19, 2024 •
edited
Loading

What's changed

Adapted the specification of joins

Change checklist

  • updated ontology, where necessary
  • updated shapes, where necessary
  • added or updated test cases, where necessary
  • any TODOs have been turned into trackable issues and referenced where necessary

Issue reference

@elsdvlee elsdvlee requested a review from pmaria July 19, 2024 14:04
pmaria
pmaria requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@pmaria pmaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some minor comments.

pmaria
pmaria approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@pmaria pmaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments

elsdvlee and others added 2 commits July 31, 2024 15:43
@elsdvlee elsdvlee merged commit 8fc6d70 into main Jul 31, 2024
1 check failed
@elsdvlee elsdvlee deleted the joins branch July 31, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmaria pmaria pmaria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsdvlee @pmaria