use list instead of set to define the result of expression and define empty value handling (#121 & #16) #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanVanAssche
force-pushed
the
121-expression-result-list
branch
from
9e3d228 to
745d22a
Compare
Closed
DylanVanAssche
changed the title
|
Incorporate |
pmaria
commented
Jul 3, 2024
There was a problem hiding this comment.
@dachafra @DylanVanAssche there are a lot of issues with the added commits. This needs work before it can be merged.
|
@pmaria I'm just the 'messenger' here :P I am not sure how to decide or resolve your comments. These commits should have been already in a PR a long time ago. At least we have now a good review. |
|
@DylanVanAssche ok I'll attempt to resolve them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #121
fixes #16