Skip to content

refactor(web): make StateKeyMap a named export 🎼 #14018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

refactor(web): make StateKeyMap a named export 🎼 #14018

merged 1 commit into from
Jun 6, 2025

Conversation

ermshiperete
Copy link
Contributor

@ermshiperete ermshiperete commented May 21, 2025 •
edited
Loading

Test-bot: skip

@github-project-automation github-project-automation bot moved this to Todo in Keyman May 21, 2025
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label May 21, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented May 21, 2025 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title refactor(web): remove default from StateKeyMap refactor(web): remove default from StateKeyMap 🎼 May 21, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S3 milestone May 21, 2025
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label May 21, 2025
@ermshiperete ermshiperete force-pushed the refactor/web/StateKeyMap branch from c0ebb0c to 0a89e27 Compare May 21, 2025 14:55
@jahorton
Copy link
Contributor

Could we retitle PRs of this form something like "make StateKeyMap a named export"? Since that's why we're dropping the "default". The way it reads now, it sounds like there might be a property named default on StateKeyMap.

@ermshiperete
Copy link
Contributor Author

Could we retitle PRs of this form something like "make StateKeyMap a named export"? Since that's why we're dropping the "default". The way it reads now, it sounds like there might be a property named default on StateKeyMap.

Thanks, that's much better!

@ermshiperete ermshiperete changed the title refactor(web): remove default from StateKeyMap 🎼 refactor(web): make StateKeyMap a named export 🎼 May 22, 2025
@ermshiperete ermshiperete force-pushed the refactor/web/StateKeyMap branch from 0a89e27 to 024181b Compare May 23, 2025 16:43
@keyman-server keyman-server modified the milestones: A19S3, A19S4 May 26, 2025
@ermshiperete ermshiperete force-pushed the refactor/web/processoraction branch from 90d1d9a to d0112ea Compare June 5, 2025 15:41
@ermshiperete ermshiperete force-pushed the refactor/web/StateKeyMap branch from 024181b to b4163b2 Compare June 5, 2025 15:43
@ermshiperete ermshiperete requested review from mcdurdin and srl295 June 5, 2025 15:43
@ermshiperete ermshiperete marked this pull request as ready for review June 5, 2025 15:43
Base automatically changed from refactor/web/processoraction to epic/web-core June 6, 2025 10:26
@ermshiperete ermshiperete merged commit b25121f into epic/web-core Jun 6, 2025
15 of 16 checks passed
@ermshiperete ermshiperete deleted the refactor/web/StateKeyMap branch June 6, 2025 10:27
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

@mcdurdin mcdurdin Awaiting requested review from mcdurdin

Assignees
No one assigned
Labels
epic-web-core refactor web/
Projects
Keyman
Status: Done
Milestone
A19S4
Development

Successfully merging this pull request may close these issues.
4 participants
@ermshiperete @jahorton @srl295 @keyman-server