Skip to content

refactor(web): move VariableStoreDictionary to variableStore.ts 🎼 #13998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

refactor(web): move VariableStoreDictionary to variableStore.ts 🎼 #13998

merged 1 commit into from
Jun 6, 2025

Conversation

ermshiperete
Copy link
Contributor

Test-bot: skip

@github-project-automation github-project-automation bot moved this to Todo in Keyman May 20, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented May 20, 2025 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title refactor(web): move VariableStoreDictionary to variableStore.ts refactor(web): move VariableStoreDictionary to variableStore.ts 🎼 May 20, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S3 milestone May 20, 2025
@ermshiperete ermshiperete force-pushed the refactor/web/rulebehavior branch from cd5a71d to d895a33 Compare May 20, 2025 12:55
@ermshiperete ermshiperete force-pushed the refactor/web/variablestoredic branch from a7d3662 to 454f946 Compare May 20, 2025 13:17
@ermshiperete ermshiperete force-pushed the refactor/web/rulebehavior branch from d895a33 to dca5edb Compare May 21, 2025 07:40
@ermshiperete ermshiperete force-pushed the refactor/web/variablestoredic branch from 454f946 to 7a18039 Compare May 21, 2025 07:56
@keyman-server keyman-server modified the milestones: A19S3, A19S4 May 26, 2025
@ermshiperete ermshiperete force-pushed the refactor/web/rulebehavior branch from dca5edb to 1b14f5c Compare June 5, 2025 15:39
@ermshiperete ermshiperete force-pushed the refactor/web/variablestoredic branch from 7a18039 to ff28ebc Compare June 5, 2025 15:40
@ermshiperete ermshiperete requested review from mcdurdin and srl295 June 5, 2025 15:40
@ermshiperete ermshiperete marked this pull request as ready for review June 5, 2025 15:40
mcdurdin
mcdurdin approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from refactor/web/rulebehavior to epic/web-core June 6, 2025 10:25
@ermshiperete ermshiperete merged commit ef1dba8 into epic/web-core Jun 6, 2025
15 of 16 checks passed
@ermshiperete ermshiperete deleted the refactor/web/variablestoredic branch June 6, 2025 10:26
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@srl295 srl295 Awaiting requested review from srl295

Assignees
No one assigned
Labels
epic-web-core refactor web/
Projects
Keyman
Status: Done
Milestone
A19S4
Development

Successfully merging this pull request may close these issues.
3 participants
@ermshiperete @mcdurdin @keyman-server