Skip to content

Commit 3ef031e

Browse files
authored
Merge pull request kubernetes-retired#465 from adam-marek/amarek-pdb-queue
Enable PDB based gang scheduling with discrete queues.
2 parents 817cf15 + c424a30 commit 3ef031e

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

pkg/scheduler/api/job_info.go

+16-4
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import (
2323
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2424
"k8s.io/apimachinery/pkg/types"
2525

26+
"github.com/kubernetes-sigs/kube-batch/cmd/kube-batch/app/options"
2627
arbcorev1 "github.com/kubernetes-sigs/kube-batch/pkg/apis/scheduling/v1alpha1"
2728
"github.com/kubernetes-sigs/kube-batch/pkg/apis/utils"
2829
)
@@ -159,10 +160,17 @@ func (ji *JobInfo) SetPodGroup(pg *arbcorev1.PodGroup) {
159160
ji.Namespace = pg.Namespace
160161
ji.MinAvailable = pg.Spec.MinMember
161162

162-
if len(pg.Spec.Queue) == 0 {
163-
ji.Queue = QueueID(pg.Namespace)
164-
} else {
163+
//set queue name based on the available information
164+
//in the following priority order:
165+
// 1. queue name from PodGroup spec (if available)
166+
// 2. queue name from default-queue command line option (if specified)
167+
// 3. namespace name
168+
if len(pg.Spec.Queue) > 0 {
165169
ji.Queue = QueueID(pg.Spec.Queue)
170+
} else if len(options.Options().DefaultQueue) > 0 {
171+
ji.Queue = QueueID(options.Options().DefaultQueue)
172+
} else {
173+
ji.Queue = QueueID(pg.Namespace)
166174
}
167175

168176
ji.CreationTimestamp = pg.GetCreationTimestamp()
@@ -173,7 +181,11 @@ func (ji *JobInfo) SetPDB(pdb *policyv1.PodDisruptionBudget) {
173181
ji.Name = pdb.Name
174182
ji.MinAvailable = pdb.Spec.MinAvailable.IntVal
175183
ji.Namespace = pdb.Namespace
176-
ji.Queue = QueueID(pdb.Namespace)
184+
if len(options.Options().DefaultQueue) == 0 {
185+
ji.Queue = QueueID(pdb.Namespace)
186+
} else {
187+
ji.Queue = QueueID(options.Options().DefaultQueue)
188+
}
177189

178190
ji.CreationTimestamp = pdb.GetCreationTimestamp()
179191
ji.PDB = pdb

0 commit comments

Comments
 (0)