Skip to content

Commit c424a30

Browse files
committed
pdb-queue renamed to default-queue; apply to PodGroup
1 parent c2c6c3a commit c424a30

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

pkg/scheduler/api/job_info.go

+12-5
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,17 @@ func (ji *JobInfo) SetPodGroup(pg *arbcorev1.PodGroup) {
160160
ji.Namespace = pg.Namespace
161161
ji.MinAvailable = pg.Spec.MinMember
162162

163-
if len(pg.Spec.Queue) == 0 {
164-
ji.Queue = QueueID(pg.Namespace)
165-
} else {
163+
//set queue name based on the available information
164+
//in the following priority order:
165+
// 1. queue name from PodGroup spec (if available)
166+
// 2. queue name from default-queue command line option (if specified)
167+
// 3. namespace name
168+
if len(pg.Spec.Queue) > 0 {
166169
ji.Queue = QueueID(pg.Spec.Queue)
170+
} else if len(options.Options().DefaultQueue) > 0 {
171+
ji.Queue = QueueID(options.Options().DefaultQueue)
172+
} else {
173+
ji.Queue = QueueID(pg.Namespace)
167174
}
168175

169176
ji.CreationTimestamp = pg.GetCreationTimestamp()
@@ -174,10 +181,10 @@ func (ji *JobInfo) SetPDB(pdb *policyv1.PodDisruptionBudget) {
174181
ji.Name = pdb.Name
175182
ji.MinAvailable = pdb.Spec.MinAvailable.IntVal
176183
ji.Namespace = pdb.Namespace
177-
if len(options.Options().PdbQueue) == 0 {
184+
if len(options.Options().DefaultQueue) == 0 {
178185
ji.Queue = QueueID(pdb.Namespace)
179186
} else {
180-
ji.Queue = QueueID(options.Options().PdbQueue)
187+
ji.Queue = QueueID(options.Options().DefaultQueue)
181188
}
182189

183190
ji.CreationTimestamp = pdb.GetCreationTimestamp()

0 commit comments

Comments
 (0)