Skip to content

Reboot Keva config #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Reboot Keva config #82

merged 1 commit into from
Dec 19, 2021

Conversation

tuhuynh27
Copy link
Member

@tuhuynh27 tuhuynh27 commented Dec 16, 2021

Fixes #81

Ref: https://redis.io/topics/config

Parameters:

Option                          Description
------                          -----------
--port <Integer>                Accept connections on the specified port (default: 6379)
--save <Boolean>                Enable save the DB to disk (default: true)
--appendonly <Boolean>          Enable append-only-file (default: false)
--appendfsync <Integer>         Define append-only fsync in ms (default: 1000)
--dir <String>                  Define working directory (default: './')
--requirepass <String>          Authenticate password (default: '' - no password)

@tuhuynh27 tuhuynh27 added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 16, 2021
@tuhuynh27 tuhuynh27 added this to the First Release milestone Dec 16, 2021
@tuhuynh27 tuhuynh27 linked an issue Dec 16, 2021 that may be closed by this pull request
@tuhuynh27
Copy link
Member Author

tuhuynh27 commented Dec 16, 2021

@axblueblader Do you have any idea on this issue?

./gradlew :app:run --args="--port 1234 --appendonly true" -> Didn't work, expected got true value
./gradlew :app:run --args="--port 1234 --appendonly false" -> Worked, got false value
./gradlew :app:run --args="--port 1234 --appendonly" -> Worked, got true value

This issue happened before this PR

@tuhuynh27 tuhuynh27 merged commit 6b3a433 into develop Dec 19, 2021
@tuhuynh27 tuhuynh27 deleted the feature/reboot-config branch December 19, 2021 14:35
@tuhuynh27 tuhuynh27 mentioned this pull request Dec 19, 2021
@axblueblader
Copy link
Member

@tuhuynh27 i think it might be a bug i made here:

return "true".equalsIgnoreCase(name) ? "true" : "false";

should have been
return "true".equalsIgnoreCase(values.get(name))

@axblueblader
Copy link
Member

relating to config stuff, also there's a 'hidden' one for file path of config file

val configFilePath = config.getArgVal("f");

tuhuynh27 added a commit that referenced this pull request Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the config arguments
2 participants