-
-
Notifications
You must be signed in to change notification settings - Fork 11
#122 Fix unit tests failed #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@TuanHungVU1202 It's fine to let these codes Because it's not about to wait for the server to start, it's about waiting for the command to execute |
@yampml @axblueblader @haphananhtuan Please help to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @TuanHungVU1202, based on your idea, I have a suggestion like the one below.
In where we want to wait until the server is available (e.g.: AbstractServerTest), just add this:
|
@taivtse Nice idea, updated |
* fix unit tests failed to create socket * update getReady method * add await() method Co-authored-by: Huynh, Tu | RASIA <[email protected]>
Fixes #122 with the suggested approach using CompletableFuture