Skip to content

fix: bug authentication errors hard to investigate without extra data in logs #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

VladimirFilonov
Copy link
Contributor

Closes #5026

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

vercel bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2025 8:45am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Bug Something isn't working labels Jun 16, 2025
@VladimirFilonov VladimirFilonov force-pushed the fix/5026-bug-authentication-errors-hard-to-investigate-without-extra-data-in-logs branch from 68a14cb to a9f7ead Compare June 16, 2025 09:21
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 16, 2025
cursor-com[bot]

This comment was marked as outdated.

shahargl
shahargl previously approved these changes Jun 16, 2025
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 16, 2025
@shahargl shahargl self-requested a review June 16, 2025 09:27
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 16, 2025
cursor-com[bot]

This comment was marked as outdated.

cursor-com[bot]

This comment was marked as outdated.

@VladimirFilonov VladimirFilonov force-pushed the fix/5026-bug-authentication-errors-hard-to-investigate-without-extra-data-in-logs branch from 9074df3 to 6c7b270 Compare June 16, 2025 13:58
Copy link

@cursor-com cursor-com bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Sensitive Data Exposed in Authentication Logs

The request body is logged in authentication error cases, exposing sensitive data (e.g., passwords, API keys, tokens) to log files. This creates a security vulnerability by storing confidential information in an insecure location.

keep/identitymanager/authverifierbase.py#L192-L199

)
self.logger.error(
"No valid authentication method found",
extra={
"headers": request.headers,
"body": body,
}
)

Fix in Cursor


Was this report helpful? Give feedback by reacting with πŸ‘ or πŸ‘Ž

@VladimirFilonov VladimirFilonov force-pushed the fix/5026-bug-authentication-errors-hard-to-investigate-without-extra-data-in-logs branch from 6c7b270 to 160c444 Compare June 17, 2025 07:17
@VladimirFilonov VladimirFilonov force-pushed the fix/5026-bug-authentication-errors-hard-to-investigate-without-extra-data-in-logs branch from 19b67fd to cd6d430 Compare June 17, 2025 08:45
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VladimirFilonov VladimirFilonov merged commit 8b9133f into main Jun 17, 2025
22 of 23 checks passed
@VladimirFilonov VladimirFilonov deleted the fix/5026-bug-authentication-errors-hard-to-investigate-without-extra-data-in-logs branch June 17, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[πŸ› Bug]: Authentication errors hard to investigate without extra data in logs
2 participants