-
Notifications
You must be signed in to change notification settings - Fork 994
fix: bug authentication errors hard to investigate without extra data in logs #5029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bug authentication errors hard to investigate without extra data in logs #5029
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 1 Skipped Deployment
|
68a14cb
to
a9f7ead
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
9074df3
to
6c7b270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Sensitive Data Exposed in Authentication Logs
The request body is logged in authentication error cases, exposing sensitive data (e.g., passwords, API keys, tokens) to log files. This creates a security vulnerability by storing confidential information in an insecure location.
keep/identitymanager/authverifierbase.py#L192-L199
keep/keep/identitymanager/authverifierbase.py
Lines 192 to 199 in 6c7b270
) | |
self.logger.error( | |
"No valid authentication method found", | |
extra={ | |
"headers": request.headers, | |
"body": body, | |
} | |
) |
Was this report helpful? Give feedback by reacting with π or π
6c7b270
to
160c444
Compare
19b67fd
to
cd6d430
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #5026
π Description
β Checks
βΉ Additional Information