[🐛 Bug]: Prometheus provider stores alert name as alert id

[vmax]

Describe the bug
Prometheus provider stores string values in id which breaks links in workflows:

To Reproduce
Steps to reproduce the behavior:

1. Configure Prometheus+Alertmanager to send alerts to Keep via webhook API (/backend/alerts/event)
2. Receive some events
3. Build a workflow based on those events
4. Observe 500 when clicking on the alert in "Triggered by":

Expected behavior
Generate usable UUID

Screenshots
included

Additional context

Looks like it happens here:

keep/keep/providers/prometheus_provider/prometheus_provider.py

Line 182 in 3caff53

alert_id = alert.get("id", alert.get("labels", {}).get("alertname"))

[dosubot]

Hi @vmax! I'm Dosu and I’m helping the keep team.

The Prometheus provider currently sets the alert ID using either the id field from the alert or, if that's missing, the alertname from the labels, which can result in non-unique, non-UUID values and breaks workflow links as you've seen. To generate a usable UUID for each alert, you can update the _format_alert method in prometheus_provider.py to use Python's uuid module.

Here's an example of how you could modify the alert ID assignment:

import uuid

# Inside the for alert in alerts: loop
alert_id = alert.get("id") or alert.get("labels", {}).get("alertname")
if not alert_id or not is_valid_uuid(alert_id):
    # Generate a new UUID if alert_id is missing or not a valid UUID
    alert_id = str(uuid.uuid4())

# Helper function to check if a string is a valid UUID
def is_valid_uuid(val):
    try:
        uuid.UUID(str(val))
        return True
    except ValueError:
        return False

This ensures every alert gets a unique, valid UUID as its ID, which should resolve the workflow linking issue. The rest of the alert processing logic can remain unchanged, so this should be a safe drop-in fix.
You can see the current logic in the code here:

keep/keep/providers/prometheus_provider/prometheus_provider.py

Line 182 in 3caff53

alert_id = alert.get("id", alert.get("labels", {}).get("alertname"))

Let me know if you need a more detailed example or have questions about integrating this!

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}   

[talboren]

Describe the bug Prometheus provider stores string values in id which breaks links in workflows:

**To Reproduce** Steps to reproduce the behavior:

1. Configure Prometheus+Alertmanager to send alerts to Keep via webhook API (/backend/alerts/event)
2. Receive some events
3. Build a workflow based on those events
4. Observe 500 when clicking on the alert in "Triggered by":

**Expected behavior** Generate usable UUID

Screenshots included

Additional context

Looks like it happens here:

keep/keep/providers/prometheus_provider/prometheus_provider.py

Line 182 in 3caff53

alert_id = alert.get("id", alert.get("labels", {}).get("alertname"))

A quick question @vmax: are you sending events to /backend/alerts/event or to /backend/alerts/event/prometheus? Our prometheus provider is configured so that it's extracting the id from the payload itself:

alert_id = alert.get("id", alert.get("labels", {}).get("alertname"))

or takes the alertname, if the id is not present the prometheus payload. We can theoretically just dump a newly generated uuid, but Prometheus usually sends it along.

Let me know and I can maybe craft a PR for that