Skip to content

Remove tests that use the removed tracking dataset #4695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

Conversation

deepyaman
Copy link
Member

Description

Address CI failure. Since Kedro-Datasets 7.0.0 removed the tracking dataset, the dataset referenced by these tests no longer exists.

Development notes

Alternatively considered skipping if kedro_datasets.__version__ >= "7.0.0", but that wouldn't get called in CI, unless we want to add a test on old versions...

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@deepyaman deepyaman marked this pull request as ready for review April 26, 2025 14:28
@deepyaman deepyaman requested a review from merelcht as a code owner April 26, 2025 14:28
@deepyaman deepyaman enabled auto-merge (squash) April 27, 2025 15:25
@deepyaman deepyaman merged commit 733b526 into main Apr 29, 2025
35 checks passed
@deepyaman deepyaman deleted the deepyaman-patch-1 branch April 29, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants