fix kubectl active printcolumn selector #1248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
printcolumn
condition is selecting based on wrong selector resulting in always stating empty string in theACTIVE
column.This is because somehow all condition
type
values are always justReady
There are some discrepancies with how conditions are handled in the addon and how usually they are handled in kubernetes API so I would like to propose just a simple fix for the selector. With this fix
kubectl
at least displays correctlyChecklist
Fixes ##1211