Deprecate spec.scaleTargetRef.deployment

[zroubalik]

Proposal

Let's deprecate this field to be able to support more types, not just Deployments. The same way it is done for KEDA.

kind: HTTPScaledObject
...
spec:
...
    scaleTargetRef:
        deployment: xkcd
        service: xkcd
        port: 8080

->

kind: HTTPScaledObject
...
spec:
...
    scaleTargetRef:
        name: xkcd
        kind: Deployment
        apiVersion: apps/v1
        service: xkcd
        port: 8080

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

[Leonardo-Ferreira]

Does version 0.8 of the http interceptor accepts this contract? Im currently at v8 intending to go to v10

[zroubalik]

v10 doesn't have this field, let's use the new one:

http-add-on/operator/apis/http/v1alpha1/httpscaledobject_types.go

Lines 24 to 37 in 6fa0b98

	type ScaleTargetRef struct {
	// +optional
	Name string `json:"name"`
	// +optional
	APIVersion string `json:"apiVersion,omitempty"`
	// +optional
	Kind string `json:"kind,omitempty"`
	// The name of the service to route to
	Service string `json:"service"`
	// The port to route to
	Port int32 `json:"port,omitempty"`
	// The port to route to referenced by name
	PortName string `json:"portName,omitempty"`
	}

wrt migration, v8 supports the new field, so you should be good.

[Leonardo-Ferreira]

wrt migration, v8 supports the new field, so you should be good.

thanks a lot