Revert the logic to fetch presence status from error status for RJ45 port #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
keboliu
pushed a commit
that referenced
this pull request
May 28, 2022
…port (#17) * Revert the logic to fetch presence status from error status Signed-off-by: Stephen Sun <[email protected]> * Unit test Signed-off-by: Stephen Sun <[email protected]> * Fix error Signed-off-by: Stephen Sun <[email protected]>
keboliu
added a commit
that referenced
this pull request
Jul 4, 2022
…n RJ45 ports (sonic-net#2111) * enhance show interface transceiver eeprom logic with RJ45 port support Signed-off-by: Kebo Liu <[email protected]> * enhance sfputil to support RJ45 port, exclude error status * fix sfputil issue on RJ45 port Signed-off-by: Kebo Liu <[email protected]> * [RJ45] change the way to judge port type and add more UT test case Signed-off-by: Kebo Liu <[email protected]> * [sfputil] simplity the logic for RJ45 support Signed-off-by: Kebo Liu <[email protected]> * Support sfputil show present Signed-off-by: Stephen Sun <[email protected]> * Support rj45 in sfpshow Signed-off-by: Stephen Sun <[email protected]> * Add test case for sfputil with RJ45 supported Signed-off-by: Stephen Sun <[email protected]> * Add mock data for RJ45 ports into STATE_DB Signed-off-by: Stephen Sun <[email protected]> * Add test for sfputil show for RJ45 ports Signed-off-by: Stephen Sun <[email protected]> * remove debug code in sfputil test case Signed-off-by: Kebo Liu <[email protected]> * remove unnecessary argument for format() Signed-off-by: Kebo Liu <[email protected]> * Revert the logic to fetch presence status from error status for RJ45 port (#17) * Revert the logic to fetch presence status from error status Signed-off-by: Stephen Sun <[email protected]> * Unit test Signed-off-by: Stephen Sun <[email protected]> * Fix error Signed-off-by: Stephen Sun <[email protected]> * Add test cases to cover lpmode and error status Signed-off-by: Stephen Sun <[email protected]> * add comments to describe the usage of functions to judge the port type Signed-off-by: Kebo Liu <[email protected]> * add more testcase for sfputil Signed-off-by: Kebo Liu <[email protected]> * fix typo in testcase name Signed-off-by: Kebo Liu <[email protected]> Co-authored-by: Stephen Sun <[email protected]> Co-authored-by: Stephen Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Revert the logic to fetch presence status from error status for RJ45 port
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)