🌱 Add .prow.yaml, migrate to kcp-prow #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
xrstf
changed the title
kcp-ci-bot
added
the
do-not-merge/release-note-label-needed
xrstf
changed the title
kcp-ci-bot
added
size/M
kcp-ci-bot
added
the
dco-signoff: yes
|
/lgtm |
|
LGTM label has been added. Git tree hash: bfb0670bfe69263e6c4216e4f6509bd7160efeea
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first step towards migrating this repository from Openshift's CI to kcp's own Prow. This PR adds a
.prow.yamlwith 3 new jobs, mimicing the ci/* jobs:pull-logicalcluster-verifyruns the two verify make targetspull-logicalcluster-testrunsmake testpull-logicalcluster-lintrunsmake lintI presume because Openshift's CI is still configured for this repo (see openshift/release#39639), the kcp-prow tide doesn't show up here yet, but they can be observed on https://public-prow.kcp.k8c.io/?repo=kcp-dev%2Flogicalcluster
golangci-lint had to be bumped to be compatible with the new Docker image used (see golangci/golangci-lint-action#434). I chose to bump as little as possible, just to make it compatible and not introduce new linting issues.
Fixes kcp-dev/infra#33
Release Notes: