Skip to content

🌱 WIP - Add .prow.yaml, begin migrating to kcp-prow #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented May 23, 2023

Summary

This PR is the first step towards migrating this repository from Openshift's CI to kcp's own Prow. This PR adds a .prow.yaml with 3 new jobs, mimicing the ci/* jobs:

  • pull-logicalcluster-verify runs the two verify make targets
  • pull-logicalcluster-test runs make test
  • pull-logicalcluster-lint runs make lint

I presume because Openshift's CI is still configured for this repo (see openshift/release#39639), the kcp-prow tide doesn't show up here yet, but they can be observed on https://public-prow.kcp.k8c.io/?repo=kcp-dev%2Flogicalcluster

golangci-lint had to be bumped to be compatible with the new Docker image used (see golangci/golangci-lint-action#434). I chose to bump as little as possible, just to make it compatible and not introduce new linting issues.

At the moment this PR makes use of the kubermatic/build container image to run the new jobs, simply because I am used to using it, it's public and has many tools on board. Not sure what our image strategy will be: use only upstream (like debian:latest) or build some custom images and keep them on GHCR?

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from stevekuznetsov and sttts May 23, 2023 14:33
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrstf
Copy link
Contributor Author

xrstf commented May 23, 2023

/retest

2 similar comments
@xrstf
Copy link
Contributor Author

xrstf commented May 23, 2023

/retest

@xrstf
Copy link
Contributor Author

xrstf commented May 23, 2023

/retest

@kcp-ci-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

2 similar comments
@kcp-ci-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@xrstf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test 19af918 link true /test test
ci/prow/lint 19af918 link true /test lint
ci/prow/imports 19af918 link true /test imports
ci/prow/boilerplate 19af918 link true /test boilerplate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kcp-ci-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor Author

xrstf commented May 25, 2023

/retest

@xrstf xrstf closed this May 25, 2023
@xrstf xrstf reopened this May 25, 2023
@xrstf xrstf closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants