-
Notifications
You must be signed in to change notification settings - Fork 15
🌱 WIP - Add .prow.yaml, begin migrating to kcp-prow #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xrstf: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Summary
This PR is the first step towards migrating this repository from Openshift's CI to kcp's own Prow. This PR adds a
.prow.yaml
with 3 new jobs, mimicing the ci/* jobs:pull-logicalcluster-verify
runs the two verify make targetspull-logicalcluster-test
runsmake test
pull-logicalcluster-lint
runsmake lint
I presume because Openshift's CI is still configured for this repo (see openshift/release#39639), the kcp-prow tide doesn't show up here yet, but they can be observed on https://public-prow.kcp.k8c.io/?repo=kcp-dev%2Flogicalcluster
golangci-lint had to be bumped to be compatible with the new Docker image used (see golangci/golangci-lint-action#434). I chose to bump as little as possible, just to make it compatible and not introduce new linting issues.
At the moment this PR makes use of the
kubermatic/build
container image to run the new jobs, simply because I am used to using it, it's public and has many tools on board. Not sure what our image strategy will be: use only upstream (likedebian:latest
) or build some custom images and keep them on GHCR?