-
Notifications
You must be signed in to change notification settings - Fork 55
Add wait functionality for deployments and daemonsets #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0442ef7
to
dfb782e
Compare
Thanks for the contribution. Generally this LGTM. I'm sure some users may find this useful. And since it's opt-in, there is no breaking change for everyone else. I rebased this to be able to run the tests. Previously, the tests failed during state import due to some upstream issue with the Terraform SDK. Now they fail because there's a diff because the https://github.com/kbst/terraform-provider-kustomization/actions/runs/3829517568/jobs/6516305125 |
Allow terraform to correctly report whether a deployment or daemonset has timed out becoming ready (where ready means that all pods are up to date relative to the spec)
@pst - hopefully the tests should pass now - they do on my machine now (although I'm a little worried that the wait create timeout configured in the tests might still be too short, I've already bumped it once) |
c54052e
to
86271c3
Compare
I've converted this to draft as I'm getting a very unexpected retry failure even after bumping up timeouts and retries, so need to dig into it a bit harder
|
Tests now pass now that kind has been upgraded (the upgrade means that kind starts properly, allowing pods to be scheduled), and the test suite now runs faster (in spite of wait failure tests) because it doesn't wait five minutes for the kind startup timeout |
Set wait for resources during import based on the wait setting configured (or based on default if not configured)
This is important for longer timeouts as max retries is only 20 by default
We expect successful waits to be quicker than timeout and unsuccessful waits to take longer than timeout This changes fixes the unsuccessful wait test which was failing more quickly than expected because of too many retries rather than timing out.
Sorry for the delay to merge this. I was traveling and only had access to a client provided computer that doesn't have access to my open source repositories. |
@pst no worries, it's that time of year, and you're allowed time away from the project any time! |
Could I request a new release version now that |
I'll work on cutting a release today. |
v0.9.1 is out |
Allow terraform to correctly report whether a deployment or daemonset has timed out becoming ready (where ready means that all pods are up to date relative to the spec)