Allow adding labels without also automatically injecting corresponding selectors #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great feature, super useful. I didn't know upstream Kustomize had this. Thanks for contributing this! 💯 |
|
Great ! thanks for merging so fast |
|
Release is unfortunately blocked by the tests not passing with some error from the SDK on Windows and Mac, but not Linux. I'm trying to figure out what causes this, but I'm also currently at Kubecon. |
|
The release is out now. Should be available from the Terraform registry soon. https://github.com/kbst/terraform-provider-kustomization/releases/tag/v0.8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to use
labelsin order to allow adding labels without also automatically injecting corresponding selectors.Selectors for resources such as Deployments and Services can’t be changed once the resource has been applied to a cluster. The resource needs to be recreated which break the rollout mechanism.
https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/labels/