-
Notifications
You must be signed in to change notification settings - Fork 55
Upgrade to Terraform Provider SDK v2 #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0d1d9d5
to
15878c2
Compare
@pst what are the future plans for this - the reshaping of the configuration seems like another thing that might be worth adding as a breaking change sooner rather than later This might be good to do before adding support for replacements (assuming that's a goal) Also do you have any thoughts on whether v2 makes sense as a target these days or just bite the bullet and move to framework (although framework relies on terraform 1.0.3+ which may well be a leap too far!) |
Honestly, I have no idea and no opinion. My gut feeling is, to go with framework. But I haven't looked at it. |
099696d
to
fe84ca8
Compare
|
8948260
to
7ff4171
Compare
k8s.io/apimachinery v0.23.5 and k8s.io/client-go v0.23.5 both import gnostic as github.com/google/gnostic and github.com/googleapis/gnostic respectively. Until this is resolved upstream, it seems easier to set the conflictPolicy to warn for the provider binaries.
31c6859
to
44327b2
Compare
@pst - any chance that we could have a |
The release was still in draft. So I assume you could not see it. https://github.com/kbst/terraform-provider-kustomization/releases/tag/v0.8.0-rc0 I don't think the |
I still need to update the docs for the schema changes. But you can see required changes here: kbst/catalog@f136940 Basically |
You can choose 0.8.0-rc0 in the version drop down but it will never default to the prerelease I see 0.8.0 is live now, look forward to trying it out! |
I added a feature to opt out of the compression feature entirely. Just in case. But once disabled big CRDs will continue to fail. I found one bug in |
No description provided.