Skip to content

Investigate using server side dry-runs also when creating resources #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pst opened this issue May 26, 2020 · 0 comments
Closed

Investigate using server side dry-runs also when creating resources #24

pst opened this issue May 26, 2020 · 0 comments

Comments

@pst
Copy link
Member

pst commented May 26, 2020

A PR to create a new namespace referenced a non existing namespace (due to a typo) in a kustomization.yaml namespace attribute. The Terraform plan of this change was all green, because the namespace name, while non-existent, was valid. Yet the apply naturally failed trying to create resources in a namespace that did not exist.

Currently, server side dry-runs are only used during update. Running create dry-runs should also surface above error during plan.

pst added a commit that referenced this issue Jun 15, 2022
pst added a commit that referenced this issue Jun 16, 2022
 * requires namespace to exist for namespaced resources
 * requires CRD to exist for custom objects

If namespace or CRD does not exist, the server side dry-run
result is ignored for the respective resource.
pst added a commit that referenced this issue Jun 16, 2022
 * requires namespace to exist for namespaced resources
 * requires CRD to exist for custom objects

If namespace or CRD does not exist, the server side dry-run
result is ignored for the respective resource.
@pst pst closed this as completed in be066f1 Jun 16, 2022
pst added a commit that referenced this issue Jun 16, 2022
Add server side dry-run before create fix #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant