Maintain one loader for the load_extensions session
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1 If we set a loader on the main entrance to `load_extensions`, any `load_extension`/`load_extensions` calls from within an extension can be tracked in a Set so we avoid double-loading. Essentially, if load_extensions tries to load :first and :second, but :first includes `load_extension :second` we should omit loading :second when the original `load_extensions` gets to :second in its `each { load_one _1 }` loop. This means we can avoid using `::Kernel.require` and `$LOADED_FEATURES`, and it should give us better Zeitwerk interop, though I haven't tested this yet. Then once we exit the top-level `load_extensions` we can discard the loader and all its state. Yay GC!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
If we set a loader on the main entrance to
load_extensions, anyload_extension/load_extensionscalls from within an extension canbe tracked in a Set so we avoid double-loading.
Essentially, if load_extensions tries to load :first and :second, but
:first includes
load_extension :secondwe should omit loading :secondwhen the original
load_extensionsgets to :second in itseach { load_one _1 }loop.This means we can avoid using
::Kernel.requireand$LOADED_FEATURES,and it should give us better Zeitwerk interop, though I haven't tested
this yet.
Then once we exit the top-level
load_extensionswe can discard theloader and all its state. Yay GC!