fixed api for gocd v21.2.0 #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmats
approved these changes
Sep 24, 2021
Comment on lines
+62
to
+63
| // Chart.defaults.global.defaultFontColor = 'white'; | ||
| // Chart.defaults.global.defaultFontFamily = 'Roboto'; |
There was a problem hiding this comment.
I had an issue with fonts in the chrome dev tools console, UI was broken for me, once I commented out those lines - I was able to see pipelines, not sure if it doesn't work only for me or for others as well.
| @@ -141,7 +141,7 @@ export default class GoService { | |||
| let pipelineNameToGroupName = new Object(); | |||
| pipelineGroups.forEach((pipelineGroup) => { | |||
| pipelineGroup.pipelines.map((pipeline) => { | |||
| if (pipelineNameToGroupName[pipeline.name] == undefined) { | |||
| if (pipelineNameToGroupName[pipeline.name] === undefined) { | |||
|
Thanks for this @Antonos and sorry for the late review. I'll merge this, but please answer my comment :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.