Support for level-0 properties & timestamps #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since org 9.4, property drawers are allowed & belong to a "level 0 headline". In orgparse, they should end up in OrgRootNode - moved property methods from OrgNode to OrgBaseNode & added parsing in OrgRootNode - removed obsolete todo, OrgRootNode correctly contains all lines before the first headline
- moved get_timestamps(), datelist(), rangelist() to OrgBaseNode (so they are available also in OrgRootNode) and added timestamp parsing to OrgRootNode
|
Thanks, looks good! Sorry it took me a while to get to it; I'll do a pypi release soon as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your work, I am using orgparse daily and it works great!
This pull requests adds support for property drawers & timestamps before the first headline. Since org 9.4, everything before the first headline is considered to belong to a "outline level 0" (https://orgmode.org/Changes.html#orgdd3d5c7), so I think it makes sense to attach them to our
OrgRootNode.I have basically just moved methods from
OrgNodetoOrgBaseNode, so they are available inOrgRootNode, and added the appropriate parsers inOrgRootNode.There was a comment in the code, which said it was "a hack that the root node just reads the lines before the first headline". But I think that is the correct behaviour? I have removed it therefore for now