feat(storagenode): migrate metrics to OpenTelemetry histogram wrappers #1118
+215
−309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cached_histogram_metrics_wrapper #1118 +/- ##
===================================================================
Coverage ? 79.58%
===================================================================
Files ? 178
Lines ? 21581
Branches ? 0
===================================================================
Hits ? 17176
Misses ? 3628
Partials ? 777 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ijsong
force-pushed
the
cached_histogram_metrics_wrapper
branch
from
2aa5903 to
cc195ac
Compare
ijsong
force-pushed
the
storagenode_change_metric_types_from_counter_to_histogram
branch
from
b568209 to
42a7040
Compare
ijsong
force-pushed
the
cached_histogram_metrics_wrapper
branch
from
cc195ac to
316114e
Compare
ijsong
force-pushed
the
storagenode_change_metric_types_from_counter_to_histogram
branch
from
42a7040 to
48ee4b7
Compare
ijsong
force-pushed
the
cached_histogram_metrics_wrapper
branch
from
316114e to
2184b7e
Compare
ijsong
force-pushed
the
storagenode_change_metric_types_from_counter_to_histogram
branch
from
48ee4b7 to
028c140
Compare
ijsong
force-pushed
the
cached_histogram_metrics_wrapper
branch
from
2184b7e to
bc0d663
Compare
ijsong
force-pushed
the
storagenode_change_metric_types_from_counter_to_histogram
branch
from
028c140 to
be7248a
Compare
Replace existing metrics with OpenTelemetry histogram wrappers. Convert several metric types from counters to histograms to capture measurement distributions. Converted from counter to histogram: - sn.append.preparation - sn.sequencer.operation.duration - sn.sequencer.fanout.duration - sn.writer.operation.duration - sn.committer.operation.duration - sn.committer.logs - sn.replicate.client.operation.duration - sn.replicate.duration - sn.replicate.fanout.duration Migrated to OpenTelemetry histogram wrapper (already histogram): - log_rpc.server.duration - log_rpc.server.log_entry.size - log_rpc.server.batch.size - log_rpc.server.log_entries_per_batch This improves observability by enabling distribution analysis for these metrics.
ijsong
force-pushed
the
cached_histogram_metrics_wrapper
branch
from
bc0d663 to
ffffa30
Compare
ijsong
force-pushed
the
storagenode_change_metric_types_from_counter_to_histogram
branch
from
be7248a to
f64d948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Replace existing metrics with OpenTelemetry histogram wrappers. Convert several
metric types from counters to histograms to capture measurement distributions.
Converted from counter to histogram:
Migrated to OpenTelemetry histogram wrapper (already histogram):
This improves observability by enabling distribution analysis for these metrics.