Bump aurora 0.9.0 for uki #3524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itxaka <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Itxaka <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds automated version tracking for the auroraboot image in Renovate and bumps the image tag to v0.9.0 across multiple CI workflows, while also introducing new secure-boot and TPM key flags for UKI builds.
- Added a
regexManagersentry inrenovate.jsonto watchquay.io/kairos/auroraboottags - Updated all workflows to use
quay.io/kairos/auroraboot:v0.9.0 - Enhanced UKI test steps with
--public-keys,--tpm-pcr-private-key,--sb-key, and--sb-certflags
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| renovate.json | Add regex manager to auto-pin auroraboot Docker image versions |
| .github/workflows/upload-cloud-images.yaml | Bump auroraboot image tag to v0.9.0 |
| .github/workflows/reusable-uki-test.yaml | Bump image tag and add TPM/SB key flags for UKI build |
| .github/workflows/reusable-release.yaml | Update release build to use v0.9.0 tag |
| .github/workflows/reusable-build-flavor.yaml | Update flavor build to use v0.9.0 tag |
Comments suppressed due to low confidence (4)
.github/workflows/upload-cloud-images.yaml:77
- [nitpick] The auroraboot version is hardcoded here; consider extracting the tag into a single variable or workflow input to avoid manual updates in multiple places.
-v $PWD:/aurora --rm quay.io/kairos/auroraboot:v0.9.0 \
.github/workflows/reusable-uki-test.yaml:145
- [nitpick] Hardcoding the auroraboot tag in each workflow can lead to drift; consider a shared parameter or YAML anchor for the version.
quay.io/kairos/auroraboot:v0.9.0 --debug build-uki --output-dir /output/ --output-type iso \
.github/workflows/reusable-uki-test.yaml:146
- New secure-boot and TPM-related flags are added; ensure you have tests or validation in place to cover these flags and their error paths.
--public-keys /keys \
.github/workflows/reusable-build-flavor.yaml:138
- [nitpick] This workflow also hardcodes the auroraboot version; centralizing the tag definition will reduce duplication.
quay.io/kairos/auroraboot:v0.9.0 \
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It brings flag changes for UKI
Part of #3222